[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

[Jason Molenda via lldb-commits]

https://github.com/jasonmolenda approved this pull request.

A couple of small nits but looks good to me.  I do have a little concern about pulling in `llvm/ADT/AddressRanges.h` in Process.h to get llvm::AddressRange when we have an lldb_private::AddressRange, which is used in a number of places in lldb.  I'm surprised you only needed to add `lldb_private::` namespace qualifications in that TraceDumper after adding the llvm header in Process.h.  I don't have a good suggestion here but it seems like the kind of thing that's going to annoy someone once a year or so when they stumble on the ambiguity. :) 

https://github.com/llvm/llvm-project/pull/71772