[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

[David Spickett via lldb-commits]

=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/69422 at github.com>


================
@@ -89,13 +97,18 @@ bool SymbolContext::DumpStopContext(Stream *s, ExecutionContextScope *exe_scope,
       s->Printf("<");
       dumped_something = true;
     } else {
-      ConstString name;
+      ConstString name_func;
----------------
DavidSpickett wrote:

This is what I mean about the name clashes too.

You're calling the function's name name and the pattern used to match "name". It's not a name though, it's a pattern. So if you can get to a stable place with the rest of the changes, I highly recommend changing `name` to `pattern` throughout.

https://github.com/llvm/llvm-project/pull/69422