[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Mon Nov 6 21:44:03 PST 2023
================
@@ -443,6 +455,9 @@ class FileSpec {
/// The unique'd filename path.
ConstString m_filename;
+ /// The optional MD5 checksum of the file.
+ Checksum m_checksum;
+
----------------
clayborg wrote:
This will increase the byte size of every FileSpec object by 16 bytes which is not good. Can we store the checksum somewhere else? Or make a lldb_private::ChecksumFile which has a lldb_private::FileSpec + Checksum?
```
(lldb) p sizeof(llvm::MD5::MD5Result)
(unsigned long) 16
(lldb) p sizeof(lldb_private::FileSpec)
(unsigned long) 24
```
https://github.com/llvm/llvm-project/pull/71459
More information about the lldb-commits
mailing list