[Lldb-commits] [lldb] [LLDB][easy] Fix a bug in DummySyntheticFrontEnd (PR #71143)

via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 2 21:54:18 PDT 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Walter Erquinigo (walter-erquinigo)

<details>
<summary>Changes</summary>

DummySyntheticFrontEnd is implementing correctly CalculateNumChildren but not MightHaveChildren, where instead of delegating its action, it was returning true.
This fixes that simple bug.


---
Full diff: https://github.com/llvm/llvm-project/pull/71143.diff


1 Files Affected:

- (modified) lldb/source/Core/ValueObjectSyntheticFilter.cpp (+1-1) 


``````````diff
diff --git a/lldb/source/Core/ValueObjectSyntheticFilter.cpp b/lldb/source/Core/ValueObjectSyntheticFilter.cpp
index 59ed780b654f3af..43bc532c4a0410b 100644
--- a/lldb/source/Core/ValueObjectSyntheticFilter.cpp
+++ b/lldb/source/Core/ValueObjectSyntheticFilter.cpp
@@ -41,7 +41,7 @@ class DummySyntheticFrontEnd : public SyntheticChildrenFrontEnd {
     return m_backend.GetIndexOfChildWithName(name);
   }
 
-  bool MightHaveChildren() override { return true; }
+  bool MightHaveChildren() override { return m_backend.MightHaveChildren(); }
 
   bool Update() override { return false; }
 };

``````````

</details>


https://github.com/llvm/llvm-project/pull/71143


More information about the lldb-commits mailing list