[Lldb-commits] [lldb] [LLDB][easy] Fix a bug in DummySyntheticFrontEnd (PR #71143)

Walter Erquinigo via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 2 21:53:45 PDT 2023


https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/71143

DummySyntheticFrontEnd is implementing correctly CalculateNumChildren but not MightHaveChildren, where instead of delegating its action, it was returning true.
This fixes that simple bug.


>From 57d19fdd476b293a87f1c14b743ba636350af7a1 Mon Sep 17 00:00:00 2001
From: walter erquinigo <walter at modular.com>
Date: Fri, 3 Nov 2023 00:50:36 -0400
Subject: [PATCH] [LLDB][easy] Fix a bug in DummySyntheticFrontEnd

DummySyntheticFrontEnd is implementing correctly CalculateNumChildren but not MightHaveChildren, where instead of delegating its action, it was returning true.
This fixes that simple bug.
---
 lldb/source/Core/ValueObjectSyntheticFilter.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/source/Core/ValueObjectSyntheticFilter.cpp b/lldb/source/Core/ValueObjectSyntheticFilter.cpp
index 59ed780b654f3af..43bc532c4a0410b 100644
--- a/lldb/source/Core/ValueObjectSyntheticFilter.cpp
+++ b/lldb/source/Core/ValueObjectSyntheticFilter.cpp
@@ -41,7 +41,7 @@ class DummySyntheticFrontEnd : public SyntheticChildrenFrontEnd {
     return m_backend.GetIndexOfChildWithName(name);
   }
 
-  bool MightHaveChildren() override { return true; }
+  bool MightHaveChildren() override { return m_backend.MightHaveChildren(); }
 
   bool Update() override { return false; }
 };



More information about the lldb-commits mailing list