[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)
Adrian Prantl via lldb-commits
lldb-commits at lists.llvm.org
Sun Oct 8 16:38:46 PDT 2023
================
@@ -173,7 +173,16 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
ExpressionResults expr_result =
- target.EvaluateExpression(expr, exe_scope, valobj_sp, eval_options);
+ target.EvaluateExpression(expr, exe_scope, valobj_sp, eval_options, &m_fixed_expression);
+
+ // Only mention Fix-Its if the command applies them.
+ // The compiler errors can address any parsing issues after applying Fix-It(s).
----------------
adrian-prantl wrote:
Ah! The original comment makes more sense: I *think* what it's trying to say is:
LLDB only displays fixits if the expression evaluator applied them. Any compiler diagnostics LLDB displays refer to the modified expression with the fixit applied.
https://github.com/llvm/llvm-project/pull/68452
More information about the lldb-commits
mailing list