[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)
Adrian Prantl via lldb-commits
lldb-commits at lists.llvm.org
Sun Oct 8 16:35:22 PDT 2023
================
@@ -172,8 +172,18 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
{
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
- ExpressionResults expr_result =
- target.EvaluateExpression(expr, exe_scope, valobj_sp, eval_options);
+ ExpressionResults expr_result = target.EvaluateExpression(
+ expr, exe_scope, valobj_sp, eval_options, &m_fixed_expression);
+
+ // Only mention Fix-Its if the command applies them.
+ // The compiler errors can address any parsing issues after applying
+ // Fix-It(s).
+ if (!m_fixed_expression.empty() && target.GetEnableNotifyAboutFixIts()) {
+ Stream &error_stream = result.GetErrorStream();
+ error_stream << " Applying Fix-It to expression, changing it to:\n";
+ error_stream << " " << m_fixed_expression << "\n";
----------------
adrian-prantl wrote:
I think this could be a useful thing to look at unifying in a follow-up patch.
https://github.com/llvm/llvm-project/pull/68452
More information about the lldb-commits
mailing list