[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Fix comment regarding static data member detection (PR #68405)

via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 6 03:42:37 PDT 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

<details>
<summary>Changes</summary>

Fixes misleading comment introduced in
`f74aaca63202cabb512c78fe19196ff348d436a8` (https://github.com/llvm/llvm-project/pull/68300)

---
Full diff: https://github.com/llvm/llvm-project/pull/68405.diff


1 Files Affected:

- (modified) lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp (+2-2) 


``````````diff
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
index 6e13626d2894313..d0065896b0d2292 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -2878,8 +2878,8 @@ void DWARFASTParserClang::ParseSingleMember(
     attrs.accessibility = eAccessNone;
 
   // Handle static members, which are typically members without
-  // locations. However, GCC *never* emits DW_AT_data_member_location
-  // for static data members of unions.
+  // locations. However, GCC doesn't emit DW_AT_data_member_location
+  // for any union members (regardless of linkage).
   // Non-normative text pre-DWARFv5 recommends marking static
   // data members with an DW_AT_external flag. Clang emits this consistently
   // whereas GCC emits it only for static data members if not part of an

``````````

</details>


https://github.com/llvm/llvm-project/pull/68405


More information about the lldb-commits mailing list