[Lldb-commits] [lldb] a233a49 - [lldb][DWARFASTParserClang][NFC] Fix comment regarding static data member detection (#68405)

[via lldb-commits]

Author: Michael Buch
Date: 2023-10-06T11:41:37+01:00
New Revision: a233a49b6037240adcde2dab74571fec13354a08

URL: https://github.com/llvm/llvm-project/commit/a233a49b6037240adcde2dab74571fec13354a08
DIFF: https://github.com/llvm/llvm-project/commit/a233a49b6037240adcde2dab74571fec13354a08.diff

LOG: [lldb][DWARFASTParserClang][NFC] Fix comment regarding static data member detection (#68405)

Fixes misleading comment introduced in
`f74aaca63202cabb512c78fe19196ff348d436a8`

Added: 
    

Modified: 
    lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
index 6e13626d2894313..d0065896b0d2292 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -2878,8 +2878,8 @@ void DWARFASTParserClang::ParseSingleMember(
     attrs.accessibility = eAccessNone;
 
   // Handle static members, which are typically members without
-  // locations. However, GCC *never* emits DW_AT_data_member_location
-  // for static data members of unions.
+  // locations. However, GCC doesn't emit DW_AT_data_member_location
+  // for any union members (regardless of linkage).
   // Non-normative text pre-DWARFv5 recommends marking static
   // data members with an DW_AT_external flag. Clang emits this consistently
   // whereas GCC emits it only for static data members if not part of an