[Lldb-commits] [lldb] [lldb] Add support for updating string during debug process (PR #67782)
via lldb-commits
lldb-commits at lists.llvm.org
Fri Sep 29 03:30:44 PDT 2023
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {darker}-->
:warning: Python code formatter, darker found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
darker --check --diff -r 9284b03e87df5153fe425b6b81b8402f666deb18..433d3973716cc46e1ffd7044898189f845e536f6 lldb/test/API/python_api/value/change_values/libcxx/string/TestChangeStringValue.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/multimap/TestDataFormatterGenericMultiMap.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/map/TestDataFormatterLibccMap.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/TestDataFormatterLibcxxUniquePtr.py
``````````
</details>
<details>
<summary>
View the diff from darker here.
</summary>
``````````diff
--- functionalities/data-formatter/data-formatter-stl/generic/multimap/TestDataFormatterGenericMultiMap.py 2023-09-29 10:14:24.000000 +0000
+++ functionalities/data-formatter/data-formatter-stl/generic/multimap/TestDataFormatterGenericMultiMap.py 2023-09-29 10:30:38.394519 +0000
@@ -178,40 +178,43 @@
self.expect(
"frame variable si",
substrs=[
multimap,
- 'size=4',
- '[0] = ',
+ "size=4",
+ "[0] = ",
'first = "one"',
- 'second = 1',
- '[1] = ',
+ "second = 1",
+ "[1] = ",
'first = "three"',
- 'second = 3',
- '[2] = ',
+ "second = 3",
+ "[2] = ",
'first = "two"',
- 'second = 2',
- '[3] = ',
+ "second = 2",
+ "[3] = ",
'first = "zero"',
- 'second = 0',
- ],
- )
-
- self.expect("p si",
- substrs=[multimap, 'size=4',
- '[0] = ',
+ "second = 0",
+ ],
+ )
+
+ self.expect(
+ "p si",
+ substrs=[
+ multimap,
+ "size=4",
+ "[0] = ",
'first = "one"',
- 'second = 1',
- '[1] = ',
+ "second = 1",
+ "[1] = ",
'first = "three"',
- 'second = 3',
- '[2] = ',
+ "second = 3",
+ "[2] = ",
'first = "two"',
- 'second = 2',
- '[3] = ',
+ "second = 2",
+ "[3] = ",
'first = "zero"',
- 'second = 0',
+ "second = 0",
],
)
# check that MightHaveChildren() gets it right
self.assertTrue(
@@ -242,42 +245,42 @@
self.expect(
"frame variable is",
substrs=[
multimap,
- 'size=4',
- '[0] = ',
- 'first = 1',
+ "size=4",
+ "[0] = ",
+ "first = 1",
'second = "is"',
- '[1] = ',
- 'first = 2',
+ "[1] = ",
+ "first = 2",
'second = "smart"',
- '[2] = ',
- 'first = 3',
+ "[2] = ",
+ "first = 3",
'second = "!!!"',
- '[3] = ',
- 'first = 85',
+ "[3] = ",
+ "first = 85",
'second = "goofy"',
],
)
self.expect(
"expression is",
substrs=[
multimap,
- 'size=4',
- '[0] = ',
- 'first = 1',
+ "size=4",
+ "[0] = ",
+ "first = 1",
'second = "is"',
- '[1] = ',
- 'first = 2',
+ "[1] = ",
+ "first = 2",
'second = "smart"',
- '[2] = ',
- 'first = 3',
+ "[2] = ",
+ "first = 3",
'second = "!!!"',
- '[3] = ',
- 'first = 85',
+ "[3] = ",
+ "first = 85",
'second = "goofy"',
],
)
# check that MightHaveChildren() gets it right
@@ -313,18 +316,18 @@
self.expect(
"frame variable ss",
substrs=[
multimap,
- 'size=3',
- '[0] = ',
+ "size=3",
+ "[0] = ",
'first = "casa"',
'second = "house"',
- '[1] = ',
+ "[1] = ",
'first = "ciao"',
'second = "hello"',
- '[2] = ',
+ "[2] = ",
'first = "gatto"',
'second = "cat"',
],
)
@@ -332,18 +335,18 @@
self.expect(
"expression ss",
substrs=[
multimap,
- 'size=3',
- '[0] = ',
+ "size=3",
+ "[0] = ",
'first = "casa"',
'second = "house"',
- '[1] = ',
+ "[1] = ",
'first = "ciao"',
'second = "hello"',
- '[2] = ',
+ "[2] = ",
'first = "gatto"',
'second = "cat"',
],
)
--- functionalities/data-formatter/data-formatter-stl/libcxx/map/TestDataFormatterLibccMap.py 2023-09-29 10:14:24.000000 +0000
+++ functionalities/data-formatter/data-formatter-stl/libcxx/map/TestDataFormatterLibccMap.py 2023-09-29 10:30:38.532763 +0000
@@ -184,44 +184,44 @@
lldbutil.continue_to_breakpoint(self.process(), bkpt)
self.expect(
"frame variable si",
substrs=[
- '%s::map' % ns,
- 'size=4',
- '[0] = ',
+ "%s::map" % ns,
+ "size=4",
+ "[0] = ",
'first = "one"',
- 'second = 1',
- '[1] = ',
+ "second = 1",
+ "[1] = ",
'first = "three"',
- 'second = 3',
- '[2] = ',
+ "second = 3",
+ "[2] = ",
'first = "two"',
- 'second = 2',
- '[3] = ',
+ "second = 2",
+ "[3] = ",
'first = "zero"',
- 'second = 0',
+ "second = 0",
],
)
self.expect(
"expression si",
substrs=[
- '%s::map' % ns,
- 'size=4',
- '[0] = ',
+ "%s::map" % ns,
+ "size=4",
+ "[0] = ",
'first = "one"',
- 'second = 1',
- '[1] = ',
+ "second = 1",
+ "[1] = ",
'first = "three"',
- 'second = 3',
- '[2] = ',
+ "second = 3",
+ "[2] = ",
'first = "two"',
- 'second = 2',
- '[3] = ',
+ "second = 2",
+ "[3] = ",
'first = "zero"',
- 'second = 0',
+ "second = 0",
],
)
# check that MightHaveChildren() gets it right
self.assertTrue(
@@ -251,43 +251,43 @@
lldbutil.continue_to_breakpoint(self.process(), bkpt)
self.expect(
"frame variable is",
substrs=[
- '%s::map' % ns,
- 'size=4',
- '[0] = ',
- 'first = 1',
+ "%s::map" % ns,
+ "size=4",
+ "[0] = ",
+ "first = 1",
'second = "is"',
- '[1] = ',
- 'first = 2',
+ "[1] = ",
+ "first = 2",
'second = "smart"',
- '[2] = ',
- 'first = 3',
+ "[2] = ",
+ "first = 3",
'second = "!!!"',
- '[3] = ',
- 'first = 85',
+ "[3] = ",
+ "first = 85",
'second = "goofy"',
],
)
self.expect(
"expression is",
substrs=[
- '%s::map' % ns,
- 'size=4',
- '[0] = ',
- 'first = 1',
+ "%s::map" % ns,
+ "size=4",
+ "[0] = ",
+ "first = 1",
'second = "is"',
- '[1] = ',
- 'first = 2',
+ "[1] = ",
+ "first = 2",
'second = "smart"',
- '[2] = ',
- 'first = 3',
+ "[2] = ",
+ "first = 3",
'second = "!!!"',
- '[3] = ',
- 'first = 85',
+ "[3] = ",
+ "first = 85",
'second = "goofy"',
],
)
# check that MightHaveChildren() gets it right
@@ -318,36 +318,36 @@
lldbutil.continue_to_breakpoint(self.process(), bkpt)
self.expect(
"frame variable ss",
substrs=[
- '%s::map' % ns,
- 'size=3',
- '[0] = ',
+ "%s::map" % ns,
+ "size=3",
+ "[0] = ",
'first = "casa"',
'second = "house"',
- '[1] = ',
+ "[1] = ",
'first = "ciao"',
'second = "hello"',
- '[2] = ',
+ "[2] = ",
'first = "gatto"',
'second = "cat"',
],
)
self.expect(
"expression ss",
substrs=[
- '%s::map' % ns,
- 'size=3',
- '[0] = ',
+ "%s::map" % ns,
+ "size=3",
+ "[0] = ",
'first = "casa"',
'second = "house"',
- '[1] = ',
+ "[1] = ",
'first = "ciao"',
'second = "hello"',
- '[2] = ',
+ "[2] = ",
'first = "gatto"',
'second = "cat"',
],
)
--- functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py 2023-09-29 10:14:24.000000 +0000
+++ functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py 2023-09-29 10:30:38.599135 +0000
@@ -84,9 +84,11 @@
children=[
ValueCheck(name="id", value="30"),
ValueCheck(name="name", summary='"steph"'),
],
)
- self.assertEqual(str(valobj), '(User) *__ptr_ = {\n id = 30\n name = "steph"\n}')
+ self.assertEqual(
+ str(valobj), '(User) *__ptr_ = {\n id = 30\n name = "steph"\n}'
+ )
self.expect_var_path("sp_user->id", type="int", value="30")
self.expect_var_path("sp_user->name", type="std::string", summary='"steph"')
--- functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/TestDataFormatterLibcxxUniquePtr.py 2023-09-29 10:14:24.000000 +0000
+++ functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/TestDataFormatterLibcxxUniquePtr.py 2023-09-29 10:30:38.672388 +0000
@@ -96,11 +96,13 @@
children=[
ValueCheck(name="id", value="30"),
ValueCheck(name="name", summary='"steph"'),
],
)
- self.assertEqual(str(valobj), '(User) *pointer = {\n id = 30\n name = "steph"\n}')
+ self.assertEqual(
+ str(valobj), '(User) *pointer = {\n id = 30\n name = "steph"\n}'
+ )
valobj = self.expect_var_path(
"up_non_empty_deleter",
type="std::unique_ptr<int, NonEmptyIntDeleter>",
summary="1234",
``````````
</details>
https://github.com/llvm/llvm-project/pull/67782
More information about the lldb-commits
mailing list