[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

[via lldb-commits]

=?utf-8?q?José?= L. Junior <jljuniorpb at gmail.com>,
=?utf-8?q?José?= L. Junior <jljuniorpb at gmail.com>,
=?utf-8?q?José?= L. Junior <jljuniorpb at gmail.com>,
=?utf-8?q?José?= L. Junior <jljuniorpb at gmail.com>,
=?utf-8?q?José?= L. Junior <jljuniorpb at gmail.com>,
=?utf-8?q?José?= L. Junior <jljuniorpb at gmail.com>
Message-ID:
In-Reply-To: <llvm/llvm-project/pull/67019/lldb at github.com>


jimingham wrote:

We try to only add really frequently used aliases to the default lldb set.  In particular, the "unique first one and two character" space in the lldb command set is valuable, that's for your most common every-day commands, and we try to leave as much of it open as possible for users to customize lldb for their own purposes.

In the case of "start", that overlaps with "step" so it doesn't actually take up a new slot in that one or two character space, so it's not so bad.  However, we certainly don't want to make any of the partial spellings of "step" become ambiguous.  In the lldb command line exact matches to aliases always win.  There's one for `s` but it doesn't look like there's one for `st`.  So if you are going to add `start` as an alias, you should also add an "st" alias to "thread step" since that's a much more common command.

I personally wouldn't use "start" enough to warrant having it in the default command set.  

One of the main reasons that "stopping at main" was handy in gdb was that gdb didn't originally do "future-break" so you always had to run to main to get everything loaded, then set your breakpoints.  That's not necessary in lldb (or really modern gdb's either)...  I think if you are using toy programs, stopping at main is pretty common, but I don't think it's all that common once you are debugging significant programs, main is generally pretty far from anything interesting.

But I don't have a strong opinion about that, if other people want to weigh in.

And to answer your direct question, you are right, you add aliases to the default command set by putting a new AddAlias in CommandInterpreter.cpp.

Jim


> On Sep 27, 2023, at 7:31 AM, José Lira Junior ***@***.***> wrote:
> 
> 
> What are your thoughts on creating an alias for process launch --stop-at-user-entry such as the intended start (or begin, or even run -m).
> 
> Also, if I wanted to do that, the only change would be an AddAlias in CommandInterpreter.cpp? Or there's something else?
> 
> —
> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/67019#issuecomment-1737522305>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW7K226YIHINLF4CR7TX4Q2FLANCNFSM6AAAAAA5BUJK5M>.
> You are receiving this because you were mentioned.
> 



https://github.com/llvm/llvm-project/pull/67019