[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 26 16:37:29 PDT 2023


jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.

This looks good to me, thanks for reviving this and finishing it up.  We should land before phabracator is flash frozen, we can iterate issues are found in the future.



================
Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.h:13
+// Other libraries and framework includes
+#include <optional>
+
----------------
I don't see this used anywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159101/new/

https://reviews.llvm.org/D159101



More information about the lldb-commits mailing list