[Lldb-commits] [lldb] [lldb] Add SetValueFromCString API to SyntheticFronend (PR #67309)

[via lldb-commits]

jimingham wrote:

This part of the change seems straightforward, if the synthetic child provider can set a value it will have to have this API...

But yes, if there are a bunch of patches that build on one another, if they aren't too big one patch that shows the functionality is easier to understand, or put a few substantial patches up but mark them as depending on the previous ones,  so we can get the big picture.

Jim
 

> On Sep 25, 2023, at 11:07 PM, Pavel Kosov ***@***.***> wrote:
> 
> 
> @kpdev commented on this pull request.
> 
> In lldb/include/lldb/DataFormatters/TypeSynthetic.h <https://github.com/llvm/llvm-project/pull/67309#discussion_r1336666737>:
> 
> > +  virtual bool SetValueFromCString(const char *value_str, Status &error) {
> +    return false;
> +  }
> +
> It will be used in the following patches (it is the first, two more to come). But maybe it is better to use one big patch with all changes?
> 
> —
> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/67309#discussion_r1336666737>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW7K2R2HJRZWWTZ6XWDX4JWI5ANCNFSM6AAAAAA5F4RBKA>.
> You are receiving this because you are on a team that was mentioned.
> 



https://github.com/llvm/llvm-project/pull/67309