[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 19 08:51:14 PDT 2023


DavidSpickett added a comment.

FYI I will be away next week, and the week after that Phab is supposed to be made read-only. So look to @jasonmolenda to approve in that time frame, or we can take this to a PR after that.



================
Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:133
+ABISysV_riscv::CreateInstance(ProcessSP process_sp, const ArchSpec &arch) {
+  if (process_sp) {
+    process_sp->SetCanInterpretFunctionCalls(true);
----------------
Do you know why this check is needed? Is there a specific test that hits this?

The other ABI plugins seem to sidestep this by not having to `->` on it, but that could just be luck.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159101/new/

https://reviews.llvm.org/D159101



More information about the lldb-commits mailing list