[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:262
+      // NOTE: It's unsafe to iterate through LLDB_REGNUM_GENERICs
+      // But the a registers re sequential in the RISC-V register space
+      ++reg_index;
----------------
Seems like `are` got split up here.


================
Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:203
+  size_t reg_size = m_is_rv64 ? 8 : 4;
+  size_t word_size = m_is_rv64 ? 8 : 4;
+  // Push host data onto target.
----------------
DavidSpickett wrote:
> word_size = reg_size; ?
This.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159101/new/

https://reviews.llvm.org/D159101