[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

[Kamlesh Kumar via Phabricator via lldb-commits]

kkcode0 added inline comments.


================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:114-117
+  tp = LLDB_INVALID_ADDRESS;
+  Status error;
+  return error;
+}
----------------
labath wrote:
> Is this necessary, given that the function is already stubbed out in `NativeRegisterContext`?
Thanks, it can be removed.


================
Comment at: lldb/source/Target/Thread.cpp:1651-1653
+  RegisterContext *reg_ctx = this->GetRegisterContext().get();
+  auto tp = reg_ctx->GetThreadPointer();
+  return tp;
----------------
labath wrote:
> Could this be implemented in ThreadGDBRemote directly (without going through the GDBRemoteRegisterContext)?
Yes, Thanks moved it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143698/new/

https://reviews.llvm.org/D143698