[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Just one last inline comment where we can't use the colorized string to calculate the column width and this is good to go.



================
Comment at: lldb/source/Core/Disassembler.cpp:662-663
   // consistent column spacing in these cases, unfortunately.
-  if (m_opcode_name.length() >= opcode_column_width) {
-    opcode_column_width = m_opcode_name.length() + 1;
+  if (opcode_name.length() >= opcode_column_width) {
+    opcode_column_width = opcode_name.length() + 1;
   }
----------------
still need to directly use "m_opcode_name" here instead of "opcode_name" so we don't include color codes as characters.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159164/new/

https://reviews.llvm.org/D159164