[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1801
+    FileSpecList dwo_paths;
+    FileSpec spec_to_get_name(dwo_name);
+    llvm::StringRef filename_only = spec_to_get_name.GetFilename();
----------------
Rename to "dwo_name_spec"? I think we can use this down below in following inline comments


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1804
+
+    FileSpec next_to_binary(
+        m_objfile_sp->GetFileSpec().GetDirectory().GetStringRef());
----------------
Rename to "binary_directory"?


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1808-1810
+    FileSpec dwo_name_next_to_binary(next_to_binary);
+    dwo_name_next_to_binary.AppendPathComponent(dwo_name);
+    dwo_paths.Append(dwo_name_next_to_binary);
----------------
Should we only do this if "dwo_name" is relative? Also if "comp_dir" is relative, do we want to add another path to search here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157609/new/

https://reviews.llvm.org/D157609