[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

Tue Aug 29 11:17:03 PDT 2023

bulbazord added a comment.

In D159011#4625915 <https://reviews.llvm.org/D159011#4625915>, @fdeazeve wrote:

>> I decided to make it a global object to guarantee its lifetime independent of any `PlatformRemoteGDBServer` instance. I don't mind wrapping it in a concurrent structure to guarantee thread safety though.
>
> At that point we would pretty much be re-implementing the notion of a ConstString but with a separate pool, right?
>
> By the way, feel free to disregard this discussion, I just wanted to make sure we are aware that we lost one safety we had before.

Yep, that's basically correct. It would be a ConstString but a separate pool. I also don't want to disregard your point, I think it's a good one. LLDB already has enough thread-safety issues as-is...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159011/new/

https://reviews.llvm.org/D159011