[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

[Felipe de Azevedo Piovezan via Phabricator via lldb-commits]

fdeazeve added a comment.

> I decided to make it a global object to guarantee its lifetime independent of any `PlatformRemoteGDBServer` instance. I don't mind wrapping it in a concurrent structure to guarantee thread safety though.

At that point we would pretty much be re-implementing the notion of a ConstString but with a separate pool, right?

By the way, feel free to disregard this discussion, I just wanted to make sure we are aware that we lost one safety we had before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159011/new/

https://reviews.llvm.org/D159011