[Lldb-commits] [PATCH] D157000: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid accepted this revision.
omjavaid added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/test/API/commands/register/register/aarch64_sve_simd_registers/main.c:43
 
+void write_simd_regs_expr() {
+#define WRITE_SIMD(NUM)                                                        \
----------------
There is subtle difference between write_simd_regs and write_simd_regs_expr. 

BTW, cant we avoid another function and just do something like


```
#define WRITE_SIMD(NUM, I)                                                      \
  asm volatile("MOV v" #NUM ".d[0], %0\n\t"                                     \
               "MOV v" #NUM ".d[1], %0\n\t" ::"r"(NUM + I))
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157000/new/

https://reviews.llvm.org/D157000