[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

[Lily Orth-Smith via Phabricator via lldb-commits]

electriclilies added inline comments.


================
Comment at: lldb/include/lldb/DataFormatters/TypeSynthetic.h:257-262
+  virtual bool IsScripted();
 
-  virtual std::string GetDescription() = 0;
+  virtual std::string GetDescription();
 
   virtual SyntheticChildrenFrontEnd::AutoPointer
+  GetFrontEnd(ValueObject &backend);
----------------
rriddle wrote:
> Why these changes?
I thought that this was causing linking problems but it is not, so I will revert.


================
Comment at: lldb/source/Commands/CommandObjectType.cpp:2174
 
-#if LLDB_ENABLE_PYTHON
-
----------------
rriddle wrote:
> Why is this dropped?
Walter and I want to use the synthetic types from C++, but right now it's only supported in Python. The motivation behind this is to make it so that we can actually use the synthetic types. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158010/new/

https://reviews.llvm.org/D158010