[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

Tue Aug 15 11:51:34 PDT 2023

rriddle added a comment.

Moving the constructor/destructor to the cpp file makes sense to remove the "undefined reference to vtable" issues that we've seen before, but I don't understand the changes to pure virtual methods or the removal of the LLDB_ENABLE_PYTHON checks. Can you elaborate more?

================
Comment at: lldb/include/lldb/DataFormatters/TypeSynthetic.h:257-262
+  virtual bool IsScripted();

-  virtual std::string GetDescription() = 0;
+  virtual std::string GetDescription();

   virtual SyntheticChildrenFrontEnd::AutoPointer
+  GetFrontEnd(ValueObject &backend);
----------------
Why these changes?

================
Comment at: lldb/source/Commands/CommandObjectType.cpp:2174

-#if LLDB_ENABLE_PYTHON
-
----------------
Why is this dropped?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158010/new/

https://reviews.llvm.org/D158010