[Lldb-commits] [PATCH] D156919: [lldb/crashlog] Make register output match lldb ordering in legacy mode

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 2 10:52:59 PDT 2023


mib marked 2 inline comments as done.
mib added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:104
+            registers_info = None
+            if self.arch:
+                if "x86_64" == self.arch:
----------------
bulbazord wrote:
> Is there a reason to do anything if `self.arch` isn't set? (Or is set to `None`)
If we fail to parse it from the report or if it's missing (for some reasons), `self.crashlog.process_arch` will be `None`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156919/new/

https://reviews.llvm.org/D156919



More information about the lldb-commits mailing list