[Lldb-commits] [lldb] b9bb946 - [lldb] Re-enable Clang Modules in source/Host directory on macOS

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2023-07-30T13:40:56-07:00
New Revision: b9bb946ca3afa384a6376e3485bd49b09c54d743

URL: https://github.com/llvm/llvm-project/commit/b9bb946ca3afa384a6376e3485bd49b09c54d743
DIFF: https://github.com/llvm/llvm-project/commit/b9bb946ca3afa384a6376e3485bd49b09c54d743.diff

LOG: [lldb] Re-enable Clang Modules in source/Host directory on macOS

Re-enable clang modules for source/Host when targetting macOS 14 or
later, in which the underlying issue has been fixed.

Added: 
    

Modified: 
    lldb/source/Host/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/lldb/source/Host/CMakeLists.txt b/lldb/source/Host/CMakeLists.txt
index 5451c2bcf776e9..18de97275e1e9f 100644
--- a/lldb/source/Host/CMakeLists.txt
+++ b/lldb/source/Host/CMakeLists.txt
@@ -1,9 +1,10 @@
 if (APPLE AND LLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY)
   # The arpa/inet.h header used in the files here is providing a miscompiled
-  # htonl function on macOS <= 10.15 when local submodule visibility is active.
-  # Disabling modules in this directory until this is is fixed.
-  # See rdar://problem/62886385
-  remove_module_flags()
+  # htonl function on macOS < 14 when local submodule visibility is active.
+  if (CMAKE_OSX_DEPLOYMENT_TARGET VERSION_LESS 14.0)
+    # Disabling modules in this directory.
+    remove_module_flags()
+  endif()
 endif()
 
 macro(add_host_subdirectory group)