[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Looks much better, just a few questions in comments.



================
Comment at: lldb/include/lldb/API/SBProcess.h:425
+  ///     code/data masks.  Each of these can be set, or
+  ///     most commonly, eMaskTypeall can be set, when all masks are
+  ///     identical.
----------------
s/eMaskTypeall/eMaskTypeAll

(missing camel case on "All")


================
Comment at: lldb/include/lldb/API/SBProcess.h:445
+  lldb::addr_t FixDataAddress(lldb::addr_t addr);
+  lldb::addr_t FixAnyAddress(lldb::addr_t addr);
+
----------------
What does this function do? Does it try to auto detect code/data low/hi on its own assuming that specific regions are easily identifiable?


================
Comment at: lldb/source/API/SBProcess.cpp:1260-1261
+      return process_sp->GetHighmemDataAddressMask();
+    case eMaskTypeAny:
+      return process_sp->GetDataAddressMask();
+    }
----------------
Any reason we actually have a case for eMaskTypeAny? What makes this useful?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155905/new/

https://reviews.llvm.org/D155905