[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

I'm not super familiar with the MCInst class from llvm, and hadn't heard of MCInstrAnalysis.  I was looking through the llvm targets - are these MCInstrAnalysis primitives going to be implemented for all targets we support today?  I see them defined for e.g. MIPS and RISCV, but I'm not sure AArch64 does.  Does `isBranch` include other variants like `isUnconditionalBranch`?  You check if we got an MCInstrAnalysis for this target - do we get none for a target like AArch64 and fall back to our current behavior?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156086/new/

https://reviews.llvm.org/D156086