[Lldb-commits] [lldb] cf2f433 - [lldb] Remove Windows XFAIL for TestDollarInVariable.py

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 24 06:26:06 PDT 2023


Author: David Spickett
Date: 2023-07-24T13:25:34Z
New Revision: cf2f4334582b55d42a74ca61c8feafa6a85e80f4

URL: https://github.com/llvm/llvm-project/commit/cf2f4334582b55d42a74ca61c8feafa6a85e80f4
DIFF: https://github.com/llvm/llvm-project/commit/cf2f4334582b55d42a74ca61c8feafa6a85e80f4.diff

LOG: [lldb] Remove Windows XFAIL for TestDollarInVariable.py

Since 5d66f9fd8e97c05a5dba317d3ad2566e61ead1ff this test has
been upassing on Linaro's Windows on Arm lldb bot:
https://lab.llvm.org/buildbot/#/builders/219/builds/4320

I can't explain exactly how that happened, but I do see a bunch
of QEnvironment packets going by in that test. It is very likely
that the order would have been different on Windows.

Indeed, when it was xfailed back in df9051e7cfda5519f4584cda22e9ef2006517e94
the reason was not known either.

Added: 
    

Modified: 
    lldb/test/API/commands/expression/dollar-in-variable/TestDollarInVariable.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/expression/dollar-in-variable/TestDollarInVariable.py b/lldb/test/API/commands/expression/dollar-in-variable/TestDollarInVariable.py
index 06e0f83459ec4b..1b18cd137751b0 100644
--- a/lldb/test/API/commands/expression/dollar-in-variable/TestDollarInVariable.py
+++ b/lldb/test/API/commands/expression/dollar-in-variable/TestDollarInVariable.py
@@ -5,7 +5,6 @@
 
 
 class TestCase(TestBase):
-    @expectedFailureAll(oslist=["windows"])
     def test(self):
         self.build()
         lldbutil.run_to_source_breakpoint(


        


More information about the lldb-commits mailing list