[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid added inline comments.


================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:222
+      // In SIMD or Full mode, the data comes from the SVE regset. In streaming
+      // mode, it also comes from that set, so we have to switch temporarily.
+      SVEState previous_sve_state = m_sve_state;
----------------
by that set you mean NT_ARM_SVE or NT_ARM_SSVE


================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:422
+        m_sve_state = SVEState::Unknown;
+        m_sve_state_data.Invalidate();
+        m_ssve_state_data.Invalidate();
----------------
shouldnt we also invalidate all other dynamic regsets here?


================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h:116
+
+  SVEStateData m_sve_state_data;
+  SVEStateData m_ssve_state_data;
----------------
When we are in streaming mode normal state data will be invalid? If yes then can we convert this into a pointer which should be pointing to a valid state data based on current state?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154926/new/

https://reviews.llvm.org/D154926