[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid added inline comments.


================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:325
+  } else if (IsSME(reg)) {
+    // This is a pseduo so it never fails.
+    ReadSMEControl();
----------------
typo: pseudo register? 


================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1003
+  // Bit 2 indicates whether the array storage is active (not yet implemented).
+  m_sme_ctrl_reg = m_sve_state == SVEState::Streaming;
+  return {};
----------------
is there a need here to check if m_sve_state is valid?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154927/new/

https://reviews.llvm.org/D154927