[Lldb-commits] [lldb] 668a3ef - Revert "[lldb][LocateModuleCallback] Fix LocateModuleCallbackTest"

Shubham Sandeep Rastogi via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 14 08:05:09 PDT 2023


Author: Shubham Sandeep Rastogi
Date: 2023-07-14T11:05:01-04:00
New Revision: 668a3efd42e7fea19a0d331f73345f2ac13cdf4f

URL: https://github.com/llvm/llvm-project/commit/668a3efd42e7fea19a0d331f73345f2ac13cdf4f
DIFF: https://github.com/llvm/llvm-project/commit/668a3efd42e7fea19a0d331f73345f2ac13cdf4f.diff

LOG: Revert "[lldb][LocateModuleCallback] Fix LocateModuleCallbackTest"

This reverts commit fb087c17c82309404fe0ebf3505c186642a719f7.

This is because of test failures:

lldb-unit.Target/_/TargetTests/LocateModuleCallbackTest.GetOrCreateModuleWithCachedModule
lldb-unit.Target/_/TargetTests/LocateModuleCallbackTest.GetOrCreateModuleWithCachedModuleAndBreakpadSymbol

Added: 
    

Modified: 
    lldb/unittests/Target/LocateModuleCallbackTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Target/LocateModuleCallbackTest.cpp b/lldb/unittests/Target/LocateModuleCallbackTest.cpp
index 42a0790bca58f2..cd5eb4473473bb 100644
--- a/lldb/unittests/Target/LocateModuleCallbackTest.cpp
+++ b/lldb/unittests/Target/LocateModuleCallbackTest.cpp
@@ -22,7 +22,6 @@
 using namespace lldb;
 using namespace lldb_private;
 using namespace lldb_private::platform_android;
-using namespace lldb_private::platform_linux;
 using namespace lldb_private::breakpad;
 using namespace testing;
 
@@ -191,8 +190,7 @@ ProcessSP MockProcessCreateInstance(TargetSP target_sp, ListenerSP listener_sp,
 
 class LocateModuleCallbackTest : public testing::Test {
   SubsystemRAII<FileSystem, HostInfo, ObjectFileBreakpad, ObjectFileELF,
-                PlatformAndroid, PlatformLinux, SymbolFileBreakpad,
-                SymbolFileSymtab>
+                PlatformAndroid, SymbolFileBreakpad, SymbolFileSymtab>
       subsystems;
 
 public:
@@ -204,9 +202,6 @@ class LocateModuleCallbackTest : public testing::Test {
         m_test_dir);
 
     // Create Debugger.
-    ArchSpec host_arch("i386-pc-linux");
-    Platform::SetHostPlatform(
-        platform_linux::PlatformLinux::CreateInstance(true, &host_arch));
     m_debugger_sp = Debugger::CreateInstance();
     EXPECT_TRUE(m_debugger_sp);
 


        


More information about the lldb-commits mailing list