[Lldb-commits] [PATCH] D154759: [lldb][NFCI] Change type of UnwindPlan::m_source_name

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 10 17:53:11 PDT 2023


jasonmolenda added a comment.

I guess simplest is we can have all the UnwindPlan creators have a `static g_unwindplan_name` and save a pointer to that.  Each one is unique, don't need anything fancier than that. There's the risk that someone will create a new UnwindPlan and forget to make it a static string, so unwind logging would try to print random memory, but it wouldn't break normal debugging.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154759/new/

https://reviews.llvm.org/D154759



More information about the lldb-commits mailing list