[Lldb-commits] [PATCH] D154759: [lldb][NFCI] Change type of UnwindPlan::m_source_name

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 10 17:44:01 PDT 2023


jasonmolenda added a comment.

probably the real correct change is to have constant c-strings in as globals and have pointers to those.  Then you're using the same space as a ConstString in each UnwindPlan (a pointer) but creation is cheaper.  There's no dynamic aspect to the names when the UnwindPlans are created, each method creating them knows what the name will be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154759/new/

https://reviews.llvm.org/D154759



More information about the lldb-commits mailing list