[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 5 09:13:03 PDT 2023


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

In D154505#4473986 <https://reviews.llvm.org/D154505#4473986>, @bulbazord wrote:

> I'm a big fan of refactoring deeply-nested code to be flatter, so I'm happy to see this work being done! I wasn't aware of `llvm::concat` before, I probably would have used a lambda or something to do this, so it was interesting learning about that. 😄

+1 on both accounts. LGTM modulo the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154505/new/

https://reviews.llvm.org/D154505



More information about the lldb-commits mailing list