[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

Wed Jul 5 08:41:28 PDT 2023

bulbazord added a comment.

I'm a big fan of refactoring deeply-nested code to be flatter, so I'm happy to see this work being done! I wasn't aware of `llvm::concat` before, I probably would have used a lambda or something to do this, so it was interesting learning about that. 😄

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:347-348
+      uint32_t sibling_idx = so_symbol->GetSiblingIndex();
+      // The sibling index can't be less that or equal to the current index
+      // "i"
+      if (sibling_idx == UINT32_MAX) {
----------------
Besides the typo, is this comment correct? We're not verifying the claim in the comment AFAICT.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154505/new/

https://reviews.llvm.org/D154505