[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

[Kazuki Sakamoto via Phabricator via lldb-commits]

splhack created this revision.
Herald added a project: All.
splhack requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

RFC https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580

Updated Target::GetOrCreateModule to call get module callback if set.

- include/lldb/Core/Debugger.h, source/Core/Debugger.cpp
  - Changed the constructor access from private to protected for unittest mock.
  - Implemented SetTargetGetModuleCallback and CallTargetGetModuleCallbackIfSet

- include/lldb/Interpreter/ScriptInterpreter.h
  - Added CallTargetGetModuleCallback as the script interpreter interface.

- include/lldb/Target/Target.h, source/Target/Target.cpp
  - Implemented CallGetModuleCallbackIfSet.

- unittests/Target/GetModuleCallbackTest.cpp
  - Added comprehensive GetOrCreateModule tests with Debugger mock.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153734

Files:
  lldb/include/lldb/Core/Debugger.h
  lldb/include/lldb/Interpreter/ScriptInterpreter.h
  lldb/include/lldb/Target/Target.h
  lldb/source/Core/Debugger.cpp
  lldb/source/Target/Target.cpp
  lldb/unittests/Target/CMakeLists.txt
  lldb/unittests/Target/GetModuleCallbackTest.cpp
  lldb/unittests/Target/Inputs/AndroidModule.c
  lldb/unittests/Target/Inputs/AndroidModule.so
  lldb/unittests/Target/Inputs/AndroidModule.so.sym
  lldb/unittests/Target/Inputs/AndroidModule.unstripped.so

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153734.534396.patch
Type: text/x-patch
Size: 42613 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230626/e3e240ce/attachment-0001.bin>