[Lldb-commits] [PATCH] D153648: [lldb] Remove broken shared cache duplicate class handling

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 23 11:31:00 PDT 2023


jingham added a comment.

There's similar code for the runtime versions 12-15 which actually looks correct.  It seems to claim that the duplicate classes are all stuffed after the capacity in the classOffsets array and that the one that won will indeed be in that list but will not be marked as a duplicate.  It is also a little bogus, I think it would only support one duplicate.  Did it not work to fix what look like transcription errors going from the 12-15 version of this code to the 16 version?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153648/new/

https://reviews.llvm.org/D153648



More information about the lldb-commits mailing list