[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

[David Spickett via Phabricator via lldb-commits]

DavidSpickett planned changes to this revision.
DavidSpickett added inline comments.


================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:286
     src = (uint8_t *)GetMTEControl() + offset;
+  } else if (IsTLS(reg)) {
+    error = ReadTLSTPIDR();
----------------
omjavaid wrote:
> Do we need to read this register on every stop ? similar to SVE vg? May be consider moving this else if before SVE which is still optionally available in most cases.
What is the criteria for "need to"? I assume for vg we need it because that tells us the vector length, so we can handle SVE changing per stop.

In this case this register is always the same size and only the value of it can be changed. So I think the answer is no we don't need to read it on every stop. I will move it.

(later if we have SME there will be a second register, but if you have SME it's always there it doesn't come and go)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152516/new/

https://reviews.llvm.org/D152516