[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.

This looks good to me, just a minor nit above. I have not run the test myself.



================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:286
     src = (uint8_t *)GetMTEControl() + offset;
+  } else if (IsTLS(reg)) {
+    error = ReadTLSTPIDR();
----------------
Do we need to read this register on every stop ? similar to SVE vg? May be consider moving this else if before SVE which is still optionally available in most cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152516/new/

https://reviews.llvm.org/D152516