[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)
Dave Lee via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jun 2 13:51:02 PDT 2023
kastiglione added a comment.
correction: there's still an overload of `GetChildAtNamePath`, which takes a can_create value and passes it through to `GetChildMemberWithName`. However that function isn't used, and could be deleted. To delete the parameter, that overload of `GetChildMemberWithName` would need to be deleted too. In general, I'm still in favor of the conservative choice of giving it a default. Deleting it altogether is an easy follow up, if so desired.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151966/new/
https://reviews.llvm.org/D151966
More information about the lldb-commits
mailing list