[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 1 23:14:10 PDT 2023


That's an option too, which I considered. I went with this as a more
conservative change. If there's agreement to remove it then I can change it.

On Thursday, June 1, 2023, Alex Langford via Phabricator <
reviews at reviews.llvm.org> wrote:

> bulbazord added a comment.
>
> If every caller sets this to true, why not remove the argument altogether?
> It looks like `ValueObjectRegister::GetChildMemberWithName` doesn't use
> the argument, `ValueObject::GetChildMemberWithName` and
> `ValueObjectSynthetic::GetChildMemberWithName` just pass it along to
> `GetChildAtIndex`.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D151966/new/
>
> https://reviews.llvm.org/D151966
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230601/9fe3e959/attachment.html>


More information about the lldb-commits mailing list