[Lldb-commits] [PATCH] D151615: [lldb] Change GetChildMemberWithName to take a StringRef, not ConstString

[Alex Langford via Phabricator via lldb-commits]

bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.

After reading though the code and thinking about it, I believe this change is appropriate. It may or may not have a measurable impact on performance, but my bet is that it doesn't make it worse. I suppose you could stress test the C++ formatters if you really wanted to know though. Either way, thank you for doing this work!

We should probably change `CompilerType::GetIndexOfChildMemberWithName` to take a `StringRef` instead of a `const char *` as a follow-up. You're having to call `str()` and then getting the `const char *` out of that to correctly call the function which is the right thing to do but is also a little wasteful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151615/new/

https://reviews.llvm.org/D151615