[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda updated this revision to Diff 525910.
jasonmolenda added a comment.

Updating the patch to incorporate Alex's feedback, and a little further refinement with testing.  I am still doing final testing now, and mostly interested in how to create a mach-o corefile that would trigger the failure that started this fix - where lldb found enough of a dyld in a modified-memory-only corefile that it cleared the binary list, but not enough to actually load the full list of binaries out of corefile memory.  I think it may be tricky to get a corefile that meets that criteria, but I want to look into it a bit.

I suspect the actual code changes are done at this point though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150928/new/

https://reviews.llvm.org/D150928

Files:
  lldb/include/lldb/Target/DynamicLoader.h
  lldb/source/Core/DynamicLoader.cpp
  lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
  lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
  lldb/source/Symbol/LocateSymbolFileMacOSX.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150928.525910.patch
Type: text/x-patch
Size: 20037 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230526/2296d552/attachment-0001.bin>