[Lldb-commits] [PATCH] D151120: [lldb][NFCI] Merge implementations of ObjectFileMachO::GetMinimumOSVersion and ObjectFileMachO::GetSDKVersion
Jason Molenda via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon May 22 15:43:16 PDT 2023
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
This looks good to me. I spent some time trying to see if there was a clear reason for the duplicated code; it was added in `llvm-svn: 193380` in 2013 and they were very clearly identical back then. I don't see/can't think of any reason for it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151120/new/
https://reviews.llvm.org/D151120
More information about the lldb-commits
mailing list