[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

[Alex Langford via Phabricator via lldb-commits]

bulbazord added a comment.

Some more numbers:

  % hyperfine -w 3 -- "$lldb -x -b -o 'b main' -o 'r' -o 'c' -o 'b $Selector' -o 'b $NonExistentSelector' -o 'b $FullObjCName' $App"
  Benchmark 1: $lldb -x -b -o 'b main' -o 'r' -o 'c' -o 'b $Selector' -o 'b $NonExistentSelector' -o 'b $FullObjCName' $App
    Time (mean ± σ):      6.323 s ±  0.069 s    [User: 5.626 s, System: 0.301 s]
    Range (min … max):    6.224 s …  6.443 s    10 runs
  
  % hyperfine -w 3 -- "$lldb -x -b -o 'b main' -o 'r' -o 'c' -o 'b $Selector' -o 'b $NonExistentSelector' -o 'b $FullObjCName' $App"
  Benchmark 1: $lldb -x -b -o 'b main' -o 'r' -o 'c' -o 'b $Selector' -o 'b $NonExistentSelector' -o 'b $FullObjCName' $App
    Time (mean ± σ):      6.270 s ±  0.042 s    [User: 5.557 s, System: 0.313 s]
    Range (min … max):    6.210 s …  6.338 s    10 runs

I hope this is sufficient to show we're not regressing performance. I measured this a few times with and without my change and I observed that this is usually faster but they are usually within 100ms of each other.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149914/new/

https://reviews.llvm.org/D149914