[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Your test measured setting a found simple breakpoint.  That should measure filling all the names caches - we do that the first time you try to set a breakpoint of any sort.  But doesn't measure the effects on lookup.  I am guessing you will find the same "not much difference" here as well, but it would be good to test that.  So it would be good to also ensure you aren't slowing down looking for a selector by name, and looking for a selector you aren't going to find by name, and looking by full ObjC name.  But if that's also true, then I'm fine with this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149914/new/

https://reviews.llvm.org/D149914