[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

[Alex Langford via Phabricator via lldb-commits]

bulbazord added a comment.

> AssertionError: 'C:\\Users\\tcwg\\llvm-worker\\lldb-aarch64-windows\\build\\lldb-test-build.noindex\\functionalities\\process_save_core\\TestProcessSaveCore.test_save_windows_mini_dump_dwarf\\a.out' not found in ['C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/functionalities/process_save_core/TestProcessSaveCore.test_save_windows_mini_dump_dwarf\\a.out', 'C:/Windows/System32\\ntdll.dll', 'C:/Windows/System32\\kernel32.dll', 'C:/Windows/System32\\KernelBase.dll']

Looks like a path normalization issue... `GetPathAsConstString()` has a bool parameter that defaults to true for normalizing paths. The right thing for this patch to do is actually return `m_opaque_up->GetPathAsConstString().GetCString()` then instead of invoking `GetDirectory()` directly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149625/new/

https://reviews.llvm.org/D149625