[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

Muhammad Omair Javaid via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon May 15 11:49:46 PDT 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rG58e6caaba1cf: Revert "[lldb] Refactor SBFileSpec::GetDirectory" (authored by omjavaid).

Changed prior to commit:
  https://reviews.llvm.org/D149625?vs=518782&id=522285#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149625/new/

https://reviews.llvm.org/D149625

Files:
  lldb/source/API/SBFileSpec.cpp


Index: lldb/source/API/SBFileSpec.cpp
===================================================================
--- lldb/source/API/SBFileSpec.cpp
+++ lldb/source/API/SBFileSpec.cpp
@@ -114,7 +114,9 @@
 const char *SBFileSpec::GetDirectory() const {
   LLDB_INSTRUMENT_VA(this);
 
-  return m_opaque_up->GetDirectory().GetCString();
+  FileSpec directory{*m_opaque_up};
+  directory.ClearFilename();
+  return directory.GetPathAsConstString().GetCString();
 }
 
 void SBFileSpec::SetFilename(const char *filename) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149625.522285.patch
Type: text/x-patch
Size: 510 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230515/c2262bb2/attachment.bin>


More information about the lldb-commits mailing list