[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

Fri May 12 11:52:36 PDT 2023

bulbazord added a comment.

In D150418#4337243 <https://reviews.llvm.org/D150418#4337243>, @JDevlieghere wrote:

> Given the numbers I'm surprised you decided to stick with 8 rather than 4? Unless I'm reading them wrong, it seems that despite the number of allocations, it's about as fast and uses (a bit) less memory. Besides that this LGTM.

Yeah, I just forgot to update this before I published. Will update the patch before landing. Thanks for the review!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150418/new/

https://reviews.llvm.org/D150418