[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

Fri May 12 02:48:18 PDT 2023

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Given the numbers I'm surprised you decided to stick with 8 rather than 4? Unless I'm reading them wrong, it seems that despite the number of allocations, it's about as fast and uses (a bit) less memory. Besides that this LGTM.

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp:58
+      int64_t value = data.GetSLEB128(offset_ptr);
+      m_attributes.push_back(AttributeSpec(attr, form, value));
+      continue;
----------------
This could be an `emplace_back`. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150418/new/

https://reviews.llvm.org/D150418